Tumbler ported to GDBus

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Tumbler ported to GDBus

Ali Abdallah-3
Dear all,

This is to announce that tumbler has been ported to GDBus and it does
not rely anymore on dbus-glib. In addition, I removed the low level dbus
calls in favour of their glib equivalents. The gsf_msole_metadata_read
function has been deprecated, so I replaced it with
gsf_doc_meta_data_read_from_msole.

You can find the code to test at my user repo:

http://git.xfce.org/users/ali/tumbler/

Cheers,
Ali
_______________________________________________
Xfce4-dev mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce4-dev
Reply | Threaded
Open this post in threaded view
|

Re: Tumbler ported to GDBus

Harald Judt
Am 11.10.2015 um 09:27 schrieb Ali Abdallah:

> Dear all,
>
> This is to announce that tumbler has been ported to GDBus and it does
> not rely anymore on dbus-glib. In addition, I removed the low level dbus
> calls in favour of their glib equivalents. The gsf_msole_metadata_read
> function has been deprecated, so I replaced it with
> gsf_doc_meta_data_read_from_msole.
>
> You can find the code to test at my user repo:
>
> http://git.xfce.org/users/ali/tumbler/
>
> Cheers,
> Ali

I gave it a quick glance. So far, your port seems ok, except this one
possible issue I've spotted:

http://git.xfce.org/users/ali/tumbler/commit/?h=gdbus-port&id=acc901b4c430bbde7d0e08c5c4df116182af2e64
I assume the following missing closing parenthesis is a mistake?

tumblerd/tumbler-specialized-thumbnailer.c:363: if (g_variant_is_of_type
(parameters, G_VARIANT_TYPE ("(usis")))

cppcheck didn't report anything strange, building was successful and the
resulting tumblerd seems to work fine.

Though I don't want to be nitpicky, please verify your editor settings;
You seem to use different intendation rules than the tumbler ones (tabs
where spaces should be used).

Regards,
Harald


--
`Experience is the best teacher.'

PGP Key ID: 0xBA3AC516
Fingerprint: 569E 0ADA 440A 8B11 D1A2 AB47 8238 0256 BA3A C516
_______________________________________________
Xfce4-dev mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce4-dev
Reply | Threaded
Open this post in threaded view
|

Re: Tumbler ported to GDBus

Ali Abdallah-3
Fixed. Also the indentation stuff. Please let me otherwise.

Thanks,
Ali

On 10/14/2015 12:00 PM, Harald Judt wrote:

> Am 11.10.2015 um 09:27 schrieb Ali Abdallah:
>> Dear all,
>>
>> This is to announce that tumbler has been ported to GDBus and it does
>> not rely anymore on dbus-glib. In addition, I removed the low level dbus
>> calls in favour of their glib equivalents. The gsf_msole_metadata_read
>> function has been deprecated, so I replaced it with
>> gsf_doc_meta_data_read_from_msole.
>>
>> You can find the code to test at my user repo:
>>
>> http://git.xfce.org/users/ali/tumbler/
>>
>> Cheers,
>> Ali
> I gave it a quick glance. So far, your port seems ok, except this one
> possible issue I've spotted:
>
> http://git.xfce.org/users/ali/tumbler/commit/?h=gdbus-port&id=acc901b4c430bbde7d0e08c5c4df116182af2e64
> I assume the following missing closing parenthesis is a mistake?
>
> tumblerd/tumbler-specialized-thumbnailer.c:363: if (g_variant_is_of_type
> (parameters, G_VARIANT_TYPE ("(usis")))
>
> cppcheck didn't report anything strange, building was successful and the
> resulting tumblerd seems to work fine.
>
> Though I don't want to be nitpicky, please verify your editor settings;
> You seem to use different intendation rules than the tumbler ones (tabs
> where spaces should be used).
>
> Regards,
> Harald
>
>

_______________________________________________
Xfce4-dev mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce4-dev