Timezones in clock

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Timezones in clock

Viktor Semykin
Hello everyone.

I've implemented a nice widget showing world map with timezone points on
it and integrated the widget in clock panel plugin. You can find my code
here [1].

The question is, could this feature be possibly integrated to the panel
code when its quality gets good enough for it?

There are couple of questions I want to discuss too:

1. I found at least three implemetations of timezones in xfce itself and
glib: [2], [3], [4]. And in addition to them I had to create my own
implementation in [1]. Maybe we have a reason to implement featureful
time zone support in libxfce4util?

2. Timezone selection widget can be useful in other places except clock
plugin. Should it be moved to libxfce4ui?

--
best, Viktor.

[1]: https://bitbucket.org/thesame/xfce4-panel/branch/timezone-map
[2]: https://git.xfce.org/xfce/xfce4-panel/tree/plugins/clock/clock.c#n887
[3]: https://git.xfce.org/apps/orage/tree/src/tz_zoneinfo_read.c
[4]: https://developer.gnome.org/glib/stable/glib-GTimeZone.html

_______________________________________________
Xfce4-dev mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce4-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Timezones in clock

Igor Zakharov
Hi Viktor,

I think this is a good idea to have timezone widget in date and time settings dialog, thanks!
I also agree that the widget should rather be common then being implemented in different places independently.

I went through your code quickly: it's very well formatted, good job! One note, though: gtk apps usually use glib types, such as gint, gdouble, gchar, etc.

Regards,
Igor

19.07.2017, 20:52, "Viktor Semykin" <[hidden email]>:

> Hello everyone.
>
> I've implemented a nice widget showing world map with timezone points on
> it and integrated the widget in clock panel plugin. You can find my code
> here [1].
>
> The question is, could this feature be possibly integrated to the panel
> code when its quality gets good enough for it?
>
> There are couple of questions I want to discuss too:
>
> 1. I found at least three implemetations of timezones in xfce itself and
> glib: [2], [3], [4]. And in addition to them I had to create my own
> implementation in [1]. Maybe we have a reason to implement featureful
> time zone support in libxfce4util?
>
> 2. Timezone selection widget can be useful in other places except clock
> plugin. Should it be moved to libxfce4ui?
>
> --
> best, Viktor.
>
> [1]: https://bitbucket.org/thesame/xfce4-panel/branch/timezone-map
> [2]: https://git.xfce.org/xfce/xfce4-panel/tree/plugins/clock/clock.c#n887
> [3]: https://git.xfce.org/apps/orage/tree/src/tz_zoneinfo_read.c
> [4]: https://developer.gnome.org/glib/stable/glib-GTimeZone.html
>
> _______________________________________________
> Xfce4-dev mailing list
> [hidden email]
> https://mail.xfce.org/mailman/listinfo/xfce4-dev
_______________________________________________
Xfce4-dev mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce4-dev
Loading...