Thunar crashes when changing view [r20382]

[Landry Breuil]

Hi all !

Dunno if it's a bug, reporting this issue anyway.

On my system, with rev20382, when i change the view ( ThunarListView <->
ThunarIconView ), thunar crashes with this assert :

8723: assertion failed "!_dbus_transport_get_is_connected
(connection->transport )" file "dbus-connection.c" line 1797 function
_dbus_connection_last_unref
Abort

With previous revisions, it didn't crashed...

I have dbus (0.33) running, and thunar is compiled against it :
dbus      2885  0.0  0.1   2636  1224 ?        Ss   Mar13   0:00
dbus-daemon --system
lbreuil   3285  0.0  0.0   2648   504 pts/0    S+   Mar13   0:00
/usr/bin/dbus-launch --sh-syntax --exit-with-session
lbreuil   3287  0.0  0.1   2640  1244 ?        Ss   Mar13   0:00
dbus-daemon --fork --print-pid 8 --print-address 6 --session


Here is the full backtrace :
(gdb) run
Starting program: /local/bin/Thunar
Reading symbols from shared object read from target memory...done.
Loaded system supplied DSO at 0xfed000
[Thread debugging using libthread_db enabled]
[New Thread -1208207680 (LWP 8567)]
[New Thread -1211728976 (LWP 8621)]
[New Thread -1222218832 (LWP 8622)]
[Thread -1222218832 (LWP 8622) exited]
[Thread -1211728976 (LWP 8621) exited]
8567: assertion failed "!_dbus_transport_get_is_connected
(connection->transport)" file "dbus-connection.c" line 1797 function
_dbus_connection_last_unref

Program received signal SIGABRT, Aborted.
[Switching to Thread -1208207680 (LWP 8567)]
0x00fed402 in __kernel_vsyscall ()
(gdb) bt
#0  0x00fed402 in __kernel_vsyscall ()
#1  0x00b60118 in raise () from /lib/libc.so.6
#2  0x00b61888 in abort () from /lib/libc.so.6
#3  0x069786e5 in dbus_malloc () from /usr/lib/libdbus-1.so.1
#4  0x0696451a in dbus_watch_handle () from /usr/lib/libdbus-1.so.1
#5  0x06936af6 in dbus_connection_set_unix_user_function ()
    from /usr/lib/libdbus-1.so.1
#6  0x00d4cba6 in thunar_vfs_volume_manager_hal_finalize (object=0x8763c18)
     at thunar-vfs-volume-hal.c:936
#7  0x0653ec42 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#8  0x08070f0e in thunar_list_model_finalize (object=0x87637c0)
     at thunar-list-model.c:462
#9  0x0653ec42 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#10 0x0808e2f3 in thunar_standard_view_finalize (object=0x8761278)
     at thunar-standard-view.c:749
#11 0x0653ec42 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#12 0x0653ecbc in g_object_run_dispose () from /usr/lib/libgobject-2.0.so.0
#13 0x005cd1ad in gtk_object_destroy () from /usr/lib/libgtk-x11-2.0.so.0
#14 0x0068b99e in gtk_widget_destroy () from /usr/lib/libgtk-x11-2.0.so.0
#15 0x080963fc in thunar_window_action_view_changed (action=0x87210a8,
     current=0x87210a8, window=0x8711d88) at thunar-window.c:1386
#16 0x06549156 in g_cclosure_marshal_VOID__OBJECT ()
    from /usr/lib/libgobject-2.0.so.0
#17 0x0653d285 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#18 0x0654b75b in g_signal_stop_emission () from
/usr/lib/libgobject-2.0.so.0
#19 0x0654ceb0 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#20 0x0654d223 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#21 0x005daeb2 in gtk_radio_action_new () from /usr/lib/libgtk-x11-2.0.so.0
#22 0x065487e7 in g_cclosure_marshal_VOID__VOID ()
    from /usr/lib/libgobject-2.0.so.0
#23 0x0653cd9b in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
#24 0x0653d285 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#25 0x0654b3b0 in g_signal_stop_emission () from
/usr/lib/libgobject-2.0.so.0
#26 0x0654ceb0 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#27 0x0654d223 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#28 0x004ec136 in gtk_action_create_menu_item ()
    from /usr/lib/libgtk-x11-2.0.so.0
#29 0x004ec5ec in gtk_action_activate () from /usr/lib/libgtk-x11-2.0.so.0
#30 0x065487e7 in g_cclosure_marshal_VOID__VOID ()
    from /usr/lib/libgobject-2.0.so.0
#31 0x0653d285 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#32 0x0654b75b in g_signal_stop_emission () from
/usr/lib/libgobject-2.0.so.0
#33 0x0654ceb0 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#34 0x0654d223 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#35 0x0068d53d in gtk_widget_activate () from /usr/lib/libgtk-x11-2.0.so.0
#36 0x005bf93a in gtk_menu_shell_activate_item ()
    from /usr/lib/libgtk-x11-2.0.so.0
#37 0x005bfc0d in gtk_menu_shell_activate_item ()
    from /usr/lib/libgtk-x11-2.0.so.0
#38 0x005b709d in gtk_menu_reorder_child () from
/usr/lib/libgtk-x11-2.0.so.0
#39 0x005b1be2 in gtk_marshal_VOID__UINT_STRING ()
    from /usr/lib/libgtk-x11-2.0.so.0
#40 0x0653cd9b in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
#41 0x0653d285 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#42 0x0654b8e7 in g_signal_stop_emission () from
/usr/lib/libgobject-2.0.so.0
#43 0x0654cc23 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#44 0x0654d223 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#45 0x0068d743 in gtk_widget_activate () from /usr/lib/libgtk-x11-2.0.so.0
#46 0x005b0348 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#47 0x005b0784 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#48 0x001a4df6 in gdk_screen_get_setting () from
/usr/lib/libgdk-x11-2.0.so.0
#49 0x064cd4ce in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#50 0x064d04d6 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#51 0x064d07c3 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#52 0x005afa46 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#53 0x0805a297 in main (argc=1, argv=0xbf9e9a24) at main.c:196
_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev

[Benedikt Meurer-2]

Landry wrote:

> Hi all !
>
> Dunno if it's a bug, reporting this issue anyway.
>
> On my system, with rev20382, when i change the view ( ThunarListView <->
> ThunarIconView ), thunar crashes with this assert :
>
> 8723: assertion failed "!_dbus_transport_get_is_connected
> (connection->transport )" file "dbus-connection.c" line 1797 function
> _dbus_connection_last_unref
> Abort
>
> With previous revisions, it didn't crashed...

Hm, crash in dbus_connection_unref(). What would be an example for such
a previous revision?

And can you try with the lastest revision?

Benedikt
_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev

[Landry Breuil]

Benedikt Meurer wrote:

>Hm, crash in dbus_connection_unref(). What would be an example for such
>a previous revision?
>
I don't have a previous version under the hand.. will try it later.

>
>And can you try with the lastest revision?
>
Thunar doesn't compile r20454 (with and without --enable-maintainer-mode)
cc1: warnings being treated as errors
thunar-tree-view.c: In function 'thunar_tree_view_drag_scroll_timer':
thunar-tree-view.c:1611: warning: implicit declaration of function
'gtk_tree_view_get_visible_range'

Another strange thing, is that thunar is finally not compiled against my
dbus i think...

>checking for optional package dbus-glib-1 >= 0.34... not found
>
>  
>
>checking for dbus-glib-1 >= 0.23... 0.33
>checking HAL_DBUS_CFLAGS... -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>checking HAL_DBUS_LIBS... -ldbus-glib-1 -ldbus-1 -lglib-2.0
>
>  
>
>Build Configuration:
>
>* D-BUS support:        no
>* File System Monitor:  Gamin
>* GNOME Thumbnailers:   yes
>* Startup Notification: yes
>* Volume Manager:       hal
>

_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev

[Benedikt Meurer-2]

Landry wrote:
>>And can you try with the lastest revision?
>
> Thunar doesn't compile r20454 (with and without --enable-maintainer-mode)
> cc1: warnings being treated as errors
> thunar-tree-view.c: In function 'thunar_tree_view_drag_scroll_timer':
> thunar-tree-view.c:1611: warning: implicit declaration of function
> 'gtk_tree_view_get_visible_range'

Should be fixed now. Was using a GTK+ 2.8 only function (please just
report these compile errors).

> Another strange thing, is that thunar is finally not compiled against my
> dbus i think...
>
>>checking for optional package dbus-glib-1 >= 0.34... not found
>>
>>checking for dbus-glib-1 >= 0.23... 0.33
>>checking HAL_DBUS_CFLAGS... -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>>checking HAL_DBUS_LIBS... -ldbus-glib-1 -ldbus-1 -lglib-2.0
>>
>>Build Configuration:
>>
>>* D-BUS support:        no
>>* File System Monitor:  Gamin
>>* GNOME Thumbnailers:   yes
>>* Startup Notification: yes
>>* Volume Manager:       hal

For the D-BUS service we require D-BUS 0.34 or better (dbus-binding-tool
is broken in earlier versions). For the HAL connection, I was told that
0.23 should do, dunno, but it seems that D-BUS 0.23 is a bit too buggy.

Benedikt
_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev

[Landry Breuil]

Benedikt Meurer wrote:

>Landry wrote:
>  
>
>>>And can you try with the lastest revision?
>>>      
>>>
>>Thunar doesn't compile r20454 (with and without --enable-maintainer-mode)
>>cc1: warnings being treated as errors
>>thunar-tree-view.c: In function 'thunar_tree_view_drag_scroll_timer':
>>thunar-tree-view.c:1611: warning: implicit declaration of function
>>'gtk_tree_view_get_visible_range'
>>    
>>
>
>Should be fixed now. Was using a GTK+ 2.8 only function (please just
>report these compile errors).
>  
>

Fixed, thanks. With rev20456, Thunar compiles and behaves correctly when
changing view.
Landry

ps: the fact that, "when you enter a directory, the tree is expanded to
this directory", which i think simple to code, is a GREAT improvement in
usability. Thanks for your work :)
_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev

[Benedikt Meurer-2]

Landry wrote:
> ps: the fact that, "when you enter a directory, the tree is expanded to
> this directory", which i think simple to code, is a GREAT improvement in
> usability. Thanks for your work :)

It's not as easy as it seems, and I'm still not sure if the current
implementation of this feature will work properly in all cases (esp.
when removable devices are added to the tree view).

Benedikt
_______________________________________________
Thunar-dev mailing list
[hidden email]
http://foo-projects.org/mailman/listinfo/thunar-dev