[Bug 13703] New: build: Incorrect use of AC_ARG_ENABLE(tests...) results in --disable-tests enabling tests

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 13703] New: build: Incorrect use of AC_ARG_ENABLE(tests...) results in --disable-tests enabling tests

bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=13703

            Bug ID: 13703
           Summary: build: Incorrect use of AC_ARG_ENABLE(tests...)
                    results in --disable-tests enabling tests
    Classification: Xfce Core
           Product: Libxfce4ui
           Version: 4.13.3
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email], [hidden email]
  Target Milestone: 4.14

AC_ARG_ENABLE has the following usage:

  AC_ARG_ENABLE (feature, help-string, action-if-given, action-if-not-given)

The third argument is evaluated whenever the option is used in any form (i.e.
both for --enable and --disable), and the fourth otherwise.

  AC_ARG_ENABLE(tests,
    [AS_HELP_STRING([--enable-tests],[enable validation test framework
@<:@default=@<:@disabled@:>@@:>@])],
    enable_tests=yes, enable_tests=no)

means that tests will be enabled whenever --enable-tests or --disable-tests is
used, and disabled only if the option is not used at all.

You probably want to use the following instead:

  AC_ARG_ENABLE(tests,
    [AS_HELP_STRING([--enable-tests],[enable validation test framework
@<:@default=@<:@disabled@:>@@:>@])],
    enable_tests=$withval, enable_tests=no)

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 13703] build: Incorrect use of AC_ARG_ENABLE(tests...) results in --disable-tests enabling tests

bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=13703

Skunnyk <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]               |[hidden email]
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Loading...