[Bug 11412] New: segfault when GPG_AGENT_INFO is exported prior to session start

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] New: segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

            Bug ID: 11412
           Summary: segfault when GPG_AGENT_INFO is exported prior to
                    session start
    Classification: Xfce
           Product: Xfce4-session
           Version: Unspecified
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

This is with xfce4-session 4.11.1git_2fb1b8f

If I do something that probably shouldn't be done (heh), xfce4-session (I
think) segfaults on startup: export GPG_AGENT_INFO="$HOME/.gnupg/S.gpg-agent"
in any user-specific profile script causes this.

The reason I did this is attempting to work around a bug in claws-mail's
handling of newer gnupg-2.1.x:
http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3337

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Landry Breuil <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Landry Breuil <[hidden email]> ---
Do you need to have a gpg-agent running to cause the crash ?

Is there a backtrace/coredump ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

--- Comment #2 from Robby Workman <[hidden email]> ---
Aha. It's because xfce4-session/xfsm-startup.c expects the path to the socket,
pid of the agent process, and the agent protocol version (which is *exactly*
what it used to be), but I'm setting GPG_AGENT_INFO with only the socket path,
so probably xfsm_gpg_agent_pid() is unhappy. As I said, this is something that
probably shouldn't be done, and so I'm not convinced that an attempt should be
made to "fix" it in xfce. The real problem is in claws-mail, I think, but they
don't seem to agree :/  I peeked into the code there, and it looks trivial
enough to make it work with *only* new gnupg-2.1.x, but not as trivial to make
it work with either, as there's no good way to find out what version of gnupg2
is in use on the system (or at least, I'm not aware of one). Anyway, that
discussion is out of scope here, so bah. For the time being, I'll just wrap my
claws-mail invocation in a script to set the agent info in its environment and
hope the claws devs change their mind.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Robby Workman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Robby Workman <[hidden email]> ---
Sorry, forgot to change the bug status.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

--- Comment #4 from Landry Breuil <[hidden email]> ---
Hm.... i still think it's a valid bug, because xfce4-session should gracefully
handle invalid env vars and do the right thing instead of crashing.. no ?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] segfault when GPG_AGENT_INFO is exported prior to session start

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Robby Workman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #5 from Robby Workman <[hidden email]> ---
Well, that's a legitimate argument. I'll leave that decision for someone else
to make. Reopened.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] startup segfault when GPG_AGENT_INFO has incomplete information

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Robby Workman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|segfault when               |startup segfault when
                   |GPG_AGENT_INFO is exported  |GPG_AGENT_INFO has
                   |prior to session start      |incomplete information

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] startup segfault when GPG_AGENT_INFO has incomplete information

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Eric Koegel <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Eric Koegel <[hidden email]> ---
I upgraded to gnupg-2.1.2 but can't get xsfm to crash. Can you post a list of
steps to reproduce?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 11412] startup segfault when GPG_AGENT_INFO has incomplete information

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=11412

Robby Workman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|REOPENED                    |RESOLVED

--- Comment #7 from Robby Workman <[hidden email]> ---
I'm not sure if it will still crash or not, but at this point, the ugly hack I
was using isn't needed since claws-mail handles newer gnupg2 just fine. I'm
closing this as INVALID :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Loading...