[Bug 10217] New: Xflock4 doesn't knows about actual lockers

classic Classic list List threaded Threaded
65 messages Options
1234
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 10217] Xflock4 doesn't know about proper lockers

bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=10217

--- Comment #34 from Jarno Suni <[hidden email]> ---
(In reply to Guido Berhoerster from comment #32)
[...]
> > (In reply to Eric Koegel from comment #20)
[...]
> > Maybe, and how is pgrep multiuser-wise?
>
> No, for non-cooperating screensavers (i.e. which provide a cli tool like
> xscreensaver) it is impossible to reliably implement such a check,
> particularly cross-platform. Instead of adding hack upon hack for obscure
> lockers that two people actually use, this should to be turned into a
> setting. So if you want to help out, you could start turning the locking
> command into a xfconf setting.

Well, I have not seen any bug reports concerning issues with multiple users
using different screen savers simultaneously. Anyway, I may have some time for
the xfconf thing. I guess it is a big/difficult task since you have not
implemented it yet. I guess it would also help, if you contributed to it as
well, instead of ranting how utter crap xflock4 is.

On the other hand, if one uses light-locker, what for does Xfce have to know
that it is the tool used for locking screen?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 10217] Xflock4 doesn't know about proper lockers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Andrey Vihrov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 10217] Xflock4 doesn't know about proper lockers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=10217

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 10217] Xflock4 doesn't know about proper lockers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Raphael Groner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #35 from Raphael Groner <[hidden email]> ---
See also bug #11324.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 10217] Xflock4 doesn't know about proper lockers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Steve Dodier-Lazaro <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[hidden email]
           Assignee|[hidden email]          |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 6593] Yet another update for xflock4, uses separate script named command-dpms to run some lockers

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 6593: Yet another update for xflock4, uses separate script named
command-dpms to run some lockers
https://bugzilla.xfce.org/attachment.cgi?id=6593&action=edit



--- Comment #40 from Jarno Suni <[hidden email]> ---
Created attachment 6593
  --> https://bugzilla.xfce.org/attachment.cgi?id=6593&action=edit
Yet another update for xflock4, uses separate script named command-dpms to run
some lockers

Sorry, guys, this update does not include support for xfconf variable. I tried
to make this work even with older xfce4 releases, so maybe it could be
backported to fix some bugs. It uses a separate script called command-dpms to
restore dpms state after certain lockers quit. (I will upload it as a separate
attachment.)

The update is supposed to fix bug 8830, bug 9063, bug 10217, bug 10679, bug
11254, bug 11446, bug 12282, and work around bugs 9574,
https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/1536237
and
https://bugs.launchpad.net/ubuntu/+source/light-locker/+bug/1536238

The script is in debugging mode. In final release, "set -o xtrace" could be
removed or changed to "set +o xtrace", and ':/usr/local/bin' could be removed
from the PATH export.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 6594] command-dpms

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 6594: command-dpms
https://bugzilla.xfce.org/attachment.cgi?id=6594&action=edit



--- Comment #41 from Jarno Suni <[hidden email]> ---
Created attachment 6594
  --> https://bugzilla.xfce.org/attachment.cgi?id=6594&action=edit
command-dpms

Name this script as command-dpms and place in /usr/local/bin or in another
directory used by xflock4. This script handles restoring DPMS state after
locking finishes with certain lockers, so that xfpm's possible presentation
mode is working after locking ends.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 6595] Update to attachment 6593. This is more backwards compatible version of xflock4. \unalias -a added.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 6595: Update to attachment 6593. This is more backwards compatible
version of xflock4. \unalias -a added.
https://bugzilla.xfce.org/attachment.cgi?id=6595&action=edit



--- Comment #43 from Jarno Suni <[hidden email]> ---
Created attachment 6595
  --> https://bugzilla.xfce.org/attachment.cgi?id=6595&action=edit
Update to attachment 6593. This is more backwards compatible version of
xflock4. \unalias -a added.

Older version of light-locker-command, e.g. 1.4.0, does not have --query
option. To support it and e.g. 1.6.0, a more complicated check is done as for
light-locker. (Note
https://bugs.launchpad.net/ubuntu/+source/light-locker/+bug/1536238). Simpler
script can be used, if you know the version of light-locker that is used with
the script.

As another update, added in the beginning "\unalias -a" to clean the table of
aliases just in case.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 6604] xflock4 for new light-locker that supports --query option

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 6604: xflock4 for new light-locker that supports --query option
https://bugzilla.xfce.org/attachment.cgi?id=6604&action=edit



--- Comment #45 from Jarno Suni <[hidden email]> ---
Created attachment 6604
  --> https://bugzilla.xfce.org/attachment.cgi?id=6604&action=edit
xflock4 for new light-locker that supports --query option

Put the /usr/local/bin in the beginning of PATH so that administrator can
override distribution's xflock4.

Add \unalias -a in the beginning to disable aliases.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 6605] xflock4 that works also with an older version of light-locker.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 6605: xflock4 that works also with an older version of light-locker.
https://bugzilla.xfce.org/attachment.cgi?id=6605&action=edit



--- Comment #46 from Jarno Suni <[hidden email]> ---
Created attachment 6605
  --> https://bugzilla.xfce.org/attachment.cgi?id=6605&action=edit
xflock4 that works also with an older version of light-locker.

Put the /usr/local/bin in the beginning of PATH so that administrator can
override distribution's xflock4.

Add \unalias -a in the beginning to disable aliases.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7168] command-dpms script to be called from xflock4

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7168: command-dpms script to be called from xflock4
https://bugzilla.xfce.org/attachment.cgi?id=7168&action=edit



--- Comment #49 from Jarno Suni <[hidden email]> ---
Created attachment 7168
  --> https://bugzilla.xfce.org/attachment.cgi?id=7168&action=edit
command-dpms script to be called from xflock4

Added GPL licence text. Use portable printf instead of echo.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7169] command-dpms script to be called from xflock4

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7169: command-dpms script to be called from xflock4
https://bugzilla.xfce.org/attachment.cgi?id=7169&action=edit



--- Comment #50 from Jarno Suni <[hidden email]> ---
Created attachment 7169
  --> https://bugzilla.xfce.org/attachment.cgi?id=7169&action=edit
command-dpms script to be called from xflock4

changed content type to plain text so that you can see the file in browser.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7170] xflock4 for new light-locker that supports --query option

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7170: xflock4 for new light-locker that supports --query option
https://bugzilla.xfce.org/attachment.cgi?id=7170&action=edit



--- Comment #51 from Jarno Suni <[hidden email]> ---
Created attachment 7170
  --> https://bugzilla.xfce.org/attachment.cgi?id=7170&action=edit
xflock4 for new light-locker that supports --query option

Remove comment about 'which'. Aliases do not seem to be an issue in
non-interactive shell. zsh. zsh can not make an array by 'set'. Who uses zsh as
sh anyway? Even using bash is potentially unsafe, as even regular builtins can
be shadowed by shell functions exported from environment.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7171] xflock4 that works also with an older version of light-locker.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7171: xflock4 that works also with an older version of light-locker.
https://bugzilla.xfce.org/attachment.cgi?id=7171&action=edit



--- Comment #52 from Jarno Suni <[hidden email]> ---
Created attachment 7171
  --> https://bugzilla.xfce.org/attachment.cgi?id=7171&action=edit
xflock4 that works also with an older version of light-locker.

Removed comment about 'which' from this, too. Do not enable xtrace option.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7172] xflock4 for new light-locker that supports --query option

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7172: xflock4 for new light-locker that supports --query option
https://bugzilla.xfce.org/attachment.cgi?id=7172&action=edit



--- Comment #53 from Jarno Suni <[hidden email]> ---
Created attachment 7172
  --> https://bugzilla.xfce.org/attachment.cgi?id=7172&action=edit
xflock4 for new light-locker that supports --query option

Correct the shebang.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7213] xflock4 that works also with an older version of light-locker.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7213: xflock4 that works also with an older version of light-locker.
https://bugzilla.xfce.org/attachment.cgi?id=7213&action=edit



--- Comment #54 from Jarno Suni <[hidden email]> ---
Created attachment 7213
  --> https://bugzilla.xfce.org/attachment.cgi?id=7213&action=edit
xflock4 that works also with an older version of light-locker.

Catch error code correctly. Highest preference is for running screensaver, then
for locker set in xfconf property. Reset IFS.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7214] xflock4 that works also with an older version of light-locker.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7214: xflock4 that works also with an older version of light-locker.
https://bugzilla.xfce.org/attachment.cgi?id=7214&action=edit



--- Comment #55 from Jarno Suni <[hidden email]> ---
Created attachment 7214
  --> https://bugzilla.xfce.org/attachment.cgi?id=7214&action=edit
xflock4 that works also with an older version of light-locker.

Handle field spitting better
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7215] xflock4 for new light-locker that supports --query option

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7215: xflock4 for new light-locker that supports --query option
https://bugzilla.xfce.org/attachment.cgi?id=7215&action=edit



--- Comment #56 from Jarno Suni <[hidden email]> ---
Created attachment 7215
  --> https://bugzilla.xfce.org/attachment.cgi?id=7215&action=edit
xflock4 for new light-locker that supports --query option

Highest preference for running screensaver, then for the locker defined in
xfconf property (channel xfce4-session, property /general/LockCommand), and
then try some predefined lockers. Handle field spitting better, e.g. quoted
arguments in the command.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7216] command-dpms script to be called from xflock4

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7216: command-dpms script to be called from xflock4
https://bugzilla.xfce.org/attachment.cgi?id=7216&action=edit



--- Comment #57 from Jarno Suni <[hidden email]> ---
Created attachment 7216
  --> https://bugzilla.xfce.org/attachment.cgi?id=7216&action=edit
command-dpms script to be called from xflock4

Handle errors and field spitting better.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

review granted: [Bug 10217] Xflock4 doesn't know about proper lockers : [Attachment 7217] xflock4 that works also with an older version of light-locker.

bugzilla-daemon
In reply to this post by bugzilla-daemon
Jarno Suni <[hidden email]> has granted  review:
Bug 10217: Xflock4 doesn't know about proper lockers
https://bugzilla.xfce.org/show_bug.cgi?id=10217

Attachment 7217: xflock4 that works also with an older version of light-locker.
https://bugzilla.xfce.org/attachment.cgi?id=7217&action=edit



--- Comment #59 from Jarno Suni <[hidden email]> ---
Created attachment 7217
  --> https://bugzilla.xfce.org/attachment.cgi?id=7217&action=edit
xflock4 that works also with an older version of light-locker.

command_dpms implemented as a shell function.
_______________________________________________
Xfce-bugs mailing list
[hidden email]
https://mail.xfce.org/mailman/listinfo/xfce-bugs
1234
Loading...